BewareMyPower commented on code in PR #139:
URL: https://github.com/apache/pulsar-client-cpp/pull/139#discussion_r1062265293
##########
lib/ConsumerImpl.cc:
##########
@@ -1209,7 +1239,28 @@ void ConsumerImpl::redeliverUnacknowledgedMessages(const
std::set<MessageId>& me
redeliverUnacknowledgedMessages();
return;
}
- redeliverMessages(messageIds);
+
+ ClientConnectionPtr cnx = getCnx().lock();
+ if (cnx) {
+ if (cnx->getServerProtocolVersion() >= proto::v2) {
+ auto needRedeliverMsgs = std::make_shared<std::set<MessageId>>();
+ auto needCallBack =
std::make_shared<std::atomic<int>>(messageIds.size());
+ auto self = get_shared_this_ptr();
+ for (const auto& msgId : messageIds) {
Review Comment:
You can add a TODO to add the `MAX_REDELIVER_UNACKNOWLEDGED` support in
future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
