michaeljmarshall opened a new pull request, #19152: URL: https://github.com/apache/pulsar/pull/19152
This reverts commit fd5037ddeab4746202539509818f2b7977698537. ### Motivation As described in https://github.com/apache/pulsar/pull/19053#pullrequestreview-1234929550, the commit to be reverted introduced a breaking change in a non-backwards compatible way. This is especially important because the datastructure in question is used for ser/de of zk metadata. Instead of making one-off changes to variable names, I would prefer to first establish a standard/spec, and then apply it generally to all names. Pulsar certainly has room to improve names, but we must prioritize the user experience when changing these names. We also need to make sure that we cover upgrade and downgrade scenarios so that we do not break environments. ### Modifications * Revert #19053. ### Verifying this change This should be trivial. ### Does this pull request potentially affect one of the following parts: This reverts a breaking change. ### Documentation - [x] `doc-not-needed` I'll send an email to the mailing list to discuss how we should handle these in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
