nicoloboschi commented on PR #19141: URL: https://github.com/apache/pulsar/pull/19141#issuecomment-1377054468
Thanks @lhotari I've renamed the methods and javadoc as you suggested. I've also replaced the `.addListener(ChannelFutureListener.FIRE_EXCEPTION_ON_FAILURE)` usages and added unit tests. Lastly, I've also added a convenience method for closing the channel after the write. PTAL again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
