shibd commented on code in PR #282:
URL:
https://github.com/apache/pulsar-client-node/pull/282#discussion_r1066658153
##########
pkg/mac/build-cpp-deps-lib.sh:
##########
@@ -166,13 +167,18 @@ if [ ! -f curl-${CURL_VERSION}.done ]; then
curl -O -L
https://github.com/curl/curl/releases/download/curl-${CURL_VERSION_}/curl-${CURL_VERSION}.tar.gz
tar xfz curl-${CURL_VERSION}.tar.gz
pushd curl-${CURL_VERSION}
+ if [ $ARCH = 'arm64' ]; then
+ SSL_CONF="--with-secure-transport"
+ else
+ SSL_CONF="--without-secure-transport --with-ssl=$PREFIX"
+ fi
Review Comment:
This parameter means disabled curl calls to Apple's native secure transport.
Refer
[here](https://github.com/curl/curl/blob/curl-7_85_0/docs/INSTALL.md#apple-platforms-macos-ios-tvos-watchos-and-their-simulator-counterparts)
I tested and the parameter doesn't work if compiled on x86_64. So when build
the x86_64, leave it as it is (using OpenSSL)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]