lhotari commented on code in PR #19161:
URL: https://github.com/apache/pulsar/pull/19161#discussion_r1066849141


##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/ObjectMapperFactory.java:
##########
@@ -109,7 +112,10 @@
 @Slf4j
 public class ObjectMapperFactory {
     public static ObjectMapper create() {
-        ObjectMapper mapper = new ObjectMapper();
+        ObjectMapper mapper = new ObjectMapper()
+                .registerModule(new ParameterNamesModule())

Review Comment:
   yes, also for applications where the Pulsar client is used. It's been a big 
mistake in Pulsar initially to not enable 
https://github.com/FasterXML/jackson-modules-java8 modules by default. 
Customizing Jackson configuration is possible, but it isn't properly 
configured. It doesn't work with the shaded client.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to