michaeljmarshall commented on code in PR #19159:
URL: https://github.com/apache/pulsar/pull/19159#discussion_r1067192865
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -3663,7 +3663,7 @@ Pair<PositionImpl, Long> getFirstPositionAndCounter() {
public void activateCursor(ManagedCursor cursor) {
synchronized (activeCursors) {
- if (activeCursors.get(cursor.getName()) == null) {
+ if (!cursor.isActive()) {
Review Comment:
If any refactoring were to be made, I think we should have switched to use
the `ManagedLedgerImpl#isCursorActive` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
