jiazhai commented on a change in pull request #4372: Fix bug of Key_Shared
Ordering
URL: https://github.com/apache/pulsar/pull/4372#discussion_r287621882
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
##########
@@ -409,15 +410,14 @@ public synchronized void readEntriesComplete(List<Entry>
entries, Object ctx) {
}
sendMessagesToConsumers(readType, entries);
-
- readMoreEntries();
}
protected void sendMessagesToConsumers(ReadType readType, List<Entry>
entries) {
int start = 0;
int entriesToDispatch = entries.size();
long totalMessagesSent = 0;
long totalBytesSent = 0;
+ AtomicInteger messagesToConsumer = new AtomicInteger(entries.size());
Review comment:
I would suggest remove this change. since we have not meet this related
issue in Shared mode, reading frequency of ledger is more controlled by other
setting.
This is mainly for message ordering, and ordering is not need for shared
mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
