merlimat commented on code in PR #19208:
URL: https://github.com/apache/pulsar/pull/19208#discussion_r1068389656
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImpl.java:
##########
@@ -78,6 +123,8 @@ public static String removeIdentifierFromMetadataURL(String
metadataURL) {
return
metadataURL.substring(EtcdMetadataStore.ETCD_SCHEME_IDENTIFIER.length());
} else if
(metadataURL.startsWith(ZKMetadataStore.ZK_SCHEME_IDENTIFIER)) {
return
metadataURL.substring(ZKMetadataStore.ZK_SCHEME_IDENTIFIER.length());
+ } else if ((provider = findProvider(metadataURL)) != null) {
Review Comment:
We could also have the `MetadataStoreProvider` for the existing
implementations and in `loadProviders()` we always go through the list of
builtin providers as well what is specified in the property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
