yuruguo commented on PR #19230:
URL: https://github.com/apache/pulsar/pull/19230#issuecomment-1382865057

   1. Whether the `deletTopic` can delete topic with the keyword `-partition-` ?
   
https://github.com/apache/pulsar/blob/fc4bca6823282c4f5375e5d48552c1f0e114b5ee/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java#L1089
   
   2. The root cause of this problem is that the conditions for creating 
partitioned topic by the `Admin API` and the `Client API` are inconsistent, as 
below:
   (1) **Admin API**
   `L165`
   
https://github.com/apache/pulsar/blob/accae9f371f87dcf0b2a2f8d4ed277b742bfdc5f/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java#L265-L268
   It is introduce in #2342
   (2) **Client API**
   `L2941`
   
https://github.com/apache/pulsar/blob/accae9f371f87dcf0b2a2f8d4ed277b742bfdc5f/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java#L2939-L2944
   It is introduce in #6846
   **So I think we should not modify the delete operation (revert this PR), 
then keep the behavior consistent for creating partitioned topic by the`Admin 
API` and the `Client API` (create a new PR).**
   
   cc @mattisonchao @codelipenghui @coderzc 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to