poorbarcode commented on code in PR #19203: URL: https://github.com/apache/pulsar/pull/19203#discussion_r1070575855
########## pulsar-broker/src/test/java/org/apache/pulsar/websocket/proxy/ProxyPingTest.java: ########## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.websocket.proxy; + +import static java.util.concurrent.TimeUnit.SECONDS; +import static org.apache.pulsar.broker.BrokerTestUtil.spyWithClassAndConstructorArgs; +import static org.assertj.core.api.Assertions.assertThat; +import static org.mockito.ArgumentMatchers.anyInt; +import static org.mockito.ArgumentMatchers.anyString; +import static org.mockito.Mockito.doReturn; +import java.net.URI; +import java.util.Optional; +import java.util.concurrent.Future; +import lombok.extern.slf4j.Slf4j; +import org.apache.pulsar.client.api.ProducerConsumerBase; +import org.apache.pulsar.metadata.impl.ZKMetadataStore; +import org.apache.pulsar.websocket.WebSocketService; +import org.apache.pulsar.websocket.service.ProxyServer; +import org.apache.pulsar.websocket.service.WebSocketProxyConfiguration; +import org.apache.pulsar.websocket.service.WebSocketServiceStarter; +import org.awaitility.Awaitility; +import org.eclipse.jetty.websocket.api.Session; +import org.eclipse.jetty.websocket.client.ClientUpgradeRequest; +import org.eclipse.jetty.websocket.client.WebSocketClient; +import org.testng.annotations.AfterMethod; +import org.testng.annotations.BeforeMethod; +import org.testng.annotations.Test; + +@Test(groups = "websocket") +@Slf4j +public class ProxyPingTest extends ProducerConsumerBase { + protected String methodName; + + private ProxyServer proxyServer; + private WebSocketService service; + + private static final int TIME_TO_CHECK_BACKLOG_QUOTA = 5; + + @BeforeMethod + public void setup() throws Exception { + conf.setBacklogQuotaCheckIntervalInSeconds(TIME_TO_CHECK_BACKLOG_QUOTA); + + super.internalSetup(); + super.producerBaseSetup(); + + WebSocketProxyConfiguration config = new WebSocketProxyConfiguration(); + config.setWebServicePort(Optional.of(0)); + config.setClusterName("test"); + config.setConfigurationMetadataStoreUrl(GLOBAL_DUMMY_VALUE); + config.setWebSocketSessionIdleTimeoutMillis(3 * 1000); + config.setWebSocketPingDurationSeconds(2); + service = spyWithClassAndConstructorArgs(WebSocketService.class, config); + doReturn(new ZKMetadataStore(mockZooKeeperGlobal)).when(service) + .createConfigMetadataStore(anyString(), anyInt()); + proxyServer = new ProxyServer(config); + WebSocketServiceStarter.start(proxyServer, service); + log.info("Proxy Server Started"); + } + + @AfterMethod(alwaysRun = true) + protected void cleanup() throws Exception { + super.internalCleanup(); + if (service != null) { + service.close(); + } + if (proxyServer != null) { + proxyServer.stop(); + } + log.info("Finished Cleaning Up Test setup"); + } + + @Test + public void testPing() throws Exception { + String producerUri = "ws://localhost:" + proxyServer.getListenPortHTTP().get() + + "/ws/v2/producer/persistent/my-property/my-ns/my-topic1/"; + + URI produceUri = URI.create(producerUri); + WebSocketClient produceClient = new WebSocketClient(); + SimpleProducerSocket produceSocket = new SimpleProducerSocket(); + + try { + produceClient.start(); + ClientUpgradeRequest produceRequest = new ClientUpgradeRequest(); + Future<Session> producerFuture = produceClient.connect(produceSocket, produceUri, produceRequest); + assertThat(producerFuture).succeedsWithin(2, SECONDS); + Session session = producerFuture.get(); + Awaitility.await().during(5, SECONDS).untilAsserted(() -> assertThat(session.isOpen()).isTrue()); Review Comment: I think we can set `during` to `10s`, then if someone changes the code of keep connections by mistake, this test will tell us that he is wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
