BewareMyPower commented on code in PR #139: URL: https://github.com/apache/pulsar-client-cpp/pull/139#discussion_r1071945567
########## lib/ProducerConfiguration.cc: ########## @@ -16,6 +16,8 @@ * specific language governing permissions and limitations * under the License. */ +#include "pulsar/ProducerConfiguration.h" Review Comment: ```suggestion #include <pulsar/ProducerConfiguration.h> ``` We usually use `<>` for headers of the Pulsar client itself. BTW, it's already included in `ProducerConfigurationImpl.h`, there is no need to add these unnecessary changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
