nicoloboschi opened a new pull request, #19258:
URL: https://github.com/apache/pulsar/pull/19258

   ### Motivation
   
   In the transaction coordinator code, most of the async execution doesn't 
properly runtime exceptions that might happens.
   The exception is not logged and the `CompletableFuture` is not completed. 
   Similar changes in past https://github.com/apache/pulsar/pull/17484
   
   
   ### Modifications
   
   * New utility method `FutureUtil#safeRunAsync(Runnable runnable, Executor 
executor, CompletableFuture completableFuture)` that completes exceptionally 
the completablefuture if an error has been caught in the runnable 
   * Added in MLTransactionMetadataStore and  TxnLogBufferedWriter
   
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local 
preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR 
description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to