lhotari opened a new pull request, #19263:
URL: https://github.com/apache/pulsar/pull/19263
### Motivation
Code coverage metrics don't currently consider integration tests and systems
tests that are run as part of the Pulsar CI pipeline. There hasn't been a way
to measure the total code coverage of Pulsar CI pipeline tests although it
would be useful to see what parts of Pulsar code base are tested and what
aren't.
### Modifications
- Add solution to Pulsar Testcontainer based integration tests so that the
Jacoco agent gets activated for processes that are run inside Docker containers
- A directory from the host is mounted in the docker container. This
directory is used for storing the Jacoco exec files.
- The code coverage should be uploaded to codecov for all public code
repositories. This is now changed so that it's possible to get coverage metrics
for builds running in a fork.
- Graceful shutdown of Java processes is needed for collecting Jacoco exec
data since by default, the Jacoco agent dumps the exec data to a file in a
shutdown hook.
- For processes managed with supervisor, it's necessary to run
"supervisorctl stop all" to trigger a graceful shutdown
- It was necessary to stop Zookeeper last for preventing shutdown
getting stuck for Brokers or Bookies.
- Creating the Jacoco XML report needed for Codecov is created using Jacoco
command line tools.
- The script has been added as part of `build/run_integration_group.sh`
script.
- The jar files of the Docker image is needed to create the XML report
from the exec files.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local
preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR
description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update
later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions
will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since
the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed
in
a forked repository.
The tests will be run in the forked repository until all PR review comments
have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
