shibd commented on PR #175: URL: https://github.com/apache/pulsar-client-cpp/pull/175#issuecomment-1385625892
I have a question: > It's because when a batched message id is constructed from deserialization, there is no getBitSet implementation of the internal acker. Is the code related to this passage here? https://github.com/apache/pulsar-client-cpp/blob/d03ff20a96de695a6c2837d62862569faf11876b/lib/MessageIdBuilder.cc#L45-L47 Is setting bitSize equal to 0 for lazy initialization? To save memory? If `bitSite` is initialized here, subsequent operations such as `ack` can reuse the logic here. Wouldn't it be better? https://github.com/apache/pulsar-client-cpp/blob/f860566c05634dd097d8941ea38a2a939fcfd26e/lib/BatchedMessageIdImpl.h#L38-L40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
