lhotari commented on PR #19264: URL: https://github.com/apache/pulsar/pull/19264#issuecomment-1386568470
It turns out that the default jacoco maven plugin resolves only dependent projects that are part of the "Maven reactor". https://github.com/jacoco/jacoco/blob/v0.8.8/jacoco-maven-plugin/src/org/jacoco/maven/ReportAggregateMojo.java#L164-L177 The dependent projects aren't part of the "Maven reactor" in the current way how we build projects once in the "Build and License check" job and then run only the tests. And someone claims that Maven is easier than Gradle. These are the times when I just wish we were using Gradle. Another issue is that the "includeCurrentProject" feature in the Jacoco maven plugin hasn't been released yet. It will be part of 0.8.9 version, https://github.com/jacoco/jacoco/pull/1007 . A [document annotation was missing](https://github.com/jacoco/jacoco/pull/1377) and that caused it to show 0.7.7 version in the docs as the version where this feature is supported. Since the Jacoco maven plugin won't be able to create a proper report of the coverage, I'll solve this by skipping the Jacoco report generation using the Maven plugin altogether and write a bash script to handle this case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
