michaeljmarshall commented on code in PR #17831:
URL: https://github.com/apache/pulsar/pull/17831#discussion_r1080836860
##########
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnection.java:
##########
@@ -523,18 +529,63 @@ remoteAddress, protocolVersionToAdvertise,
getRemoteEndpointProtocolVersion(),
@Override
protected void handleAuthResponse(CommandAuthResponse authResponse) {
- checkArgument(state == State.Connecting);
checkArgument(authResponse.hasResponse());
checkArgument(authResponse.getResponse().hasAuthData() &&
authResponse.getResponse().hasAuthMethodName());
if (LOG.isDebugEnabled()) {
LOG.debug("Received AuthResponse from {}, auth method: {}",
- remoteAddress, authResponse.getResponse().getAuthMethodName());
+ remoteAddress,
authResponse.getResponse().getAuthMethodName());
}
try {
AuthData clientData =
AuthData.of(authResponse.getResponse().getAuthData());
doAuthentication(clientData);
+ if (service.getConfiguration().isForwardAuthorizationCredentials()
Review Comment:
An interesting consequence of this change is that the `ProxyConnection` goes
back into the `Connecting` state if the authentication takes multiple steps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
