nlu90 commented on code in PR #15907:
URL: https://github.com/apache/pulsar/pull/15907#discussion_r1081625569
##########
pulsar-function-go/conf/conf.go:
##########
@@ -77,6 +77,9 @@ type Conf struct {
UserConfig string `json:"userConfig" yaml:"userConfig"`
//metrics config
MetricsPort int `json:"metricsPort" yaml:"metricsPort"`
+
+ ClientAuthPlugin string `json:"clientAuthPlugin"
yaml:"clientAuthPlugin"`
+ ClientAuthParams string `json:"clientAuthParams"
yaml:"clientAuthParams"`
Review Comment:
The convention diverged.
I'm fine with either. Let's conform to one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
