lhotari opened a new pull request, #19296: URL: https://github.com/apache/pulsar/pull/19296
### Motivation After reviewing the latest changes made in #19264 for collecting code coverage in a new way, there are a few details that need to be adjusted. The Codecov results can be seen for the PR commit at https://app.codecov.io/github/apache/pulsar/commit/62060c814bf90de9b8f7cd520e2dc5459b394cbe/tree The build workflow run contained Jacoco html reports at https://github.com/apache/pulsar/actions/runs/3961486478 . ### Modifications - use test scope classpath to collect correct dependencies - exclude test projects so that coverage doesn't get reported for them - show link to Codecov commit level report - notify as soon as 4 uploads are completed for the commit - ignore the CI status since that is often wrong in Codecov and the notification doesn't appear at all. - It's sufficient to wait for 4 uploads to happen now that it happens consistently after #19264 changes - exclude shaded classes from Jacoco instrumentation to lower Jacoco's overhead - excluded protobuf generated classes from Jacoco instrumentation ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [x] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
