BewareMyPower commented on code in PR #83:
URL:
https://github.com/apache/pulsar-client-python/pull/83#discussion_r1086521707
##########
.github/workflows/ci-pr-validation.yaml:
##########
@@ -185,9 +185,7 @@ jobs:
matrix:
python:
- version: '3.7'
- - version: '3.8'
- - version: '3.9'
Review Comment:
+1. We should not remove the build workflows for Python 3.8 to 3.10 on
Windows. It's different for Python 3.7 only on macOS build, see
https://github.com/apache/pulsar-client-python/blob/fe966041f4c1868ef5549a5f95c484ecd64e8eee/pkg/mac/build-dependencies.sh#L81-L83
For Windows build, the Python has been set up by the
`actions/setup-python@v4` plugin. /cc @erichare
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
