michaeljmarshall commented on code in PR #19153:
URL: https://github.com/apache/pulsar/pull/19153#discussion_r1087471854


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -1064,6 +1094,13 @@ public CompletableFuture<Optional<Topic>> getTopic(final 
TopicName topicName, bo
     }
 
     public CompletableFuture<Void> deleteTopic(String topic, boolean 
forceDelete) {
+        topicEventsDispatcher.notify(topic, TopicEvent.DELETE, 
EventStage.BEFORE);
+        CompletableFuture<Void> result =  deleteTopicInternal(topic, 
forceDelete);
+        topicEventsDispatcher.notifyOnCompletion(result, topic, 
TopicEvent.DELETE);

Review Comment:
   Thanks for the explanation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to