eolivelli commented on code in PR #18358:
URL: https://github.com/apache/pulsar/pull/18358#discussion_r1090354973


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientBuilderImpl.java:
##########
@@ -138,6 +139,24 @@ public ClientBuilder authentication(String 
authPluginClassName, Map<String, Stri
         return this;
     }
 
+    private void setAuthenticationFromPropsIfAvailable(ClientConfigurationData 
clientConfig) {

Review Comment:
   This change is NOT only about the "Admin" client but it is also touching the 
regular Client.
   
   Please update the title and the description



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to