codelipenghui commented on code in PR #19158:
URL: https://github.com/apache/pulsar/pull/19158#discussion_r1090351983
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/MessageAcknowledger.java:
##########
@@ -49,6 +49,8 @@ public interface MessageAcknowledger {
*
* @throws PulsarClientException.AlreadyClosedException}
* if the consumer was already closed
+ * @throws PulsarClientException.NotAllowedException
+ * if `messageId` is not a {@link TopicMessageId} when
multiple topics are subscribed
Review Comment:
And is it also for the partitioned topic? Users need to use
```java
MessageId.fromByteArrayWithTopic();
```
or
```java
TopicMessageId.create(topic, MessageId.fromByteArray());
```
Does the TopicMessageId interface is intentionally exposed to users? Which
one should be suggested in the future?
##########
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/TopicMessageId.java:
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.client.api;
+
+/**
+ * The MessageId used for a consumer that subscribes multiple topics or
partitioned topics.
+ *
+ * <p>
+ * It's guaranteed that {@link Message#getMessageId()} must return a
TopicMessageId instance if the Message is received
+ * from a consumer that subscribes multiple topics or partitioned topics.
+ * The topic name used in APIs related to this class like `getOwnerTopic` and
`create` must be the full topic name. For
+ * example, "my-topic" is invalid while "persistent://public/default/my-topic"
is valid.
+ * If the topic is a partitioned topic, the topic name should be the name of
the specific partition, e.g.
+ * "persistent://public/default/my-topic-partition-0".
+ * </p>
+ */
+public interface TopicMessageId extends MessageId {
+
+ /**
+ * Return the owner topic name of a message.
+ *
+ * @return the owner topic
+ */
+ String getOwnerTopic();
+
+ static TopicMessageId create(String topic, MessageId messageId) {
Review Comment:
We will create an anonymous implementation here. Is it better to have an
internal static class? e.g., `TopicMessageIdBase` or `TopicMessageIdWrapper`,
and then the `TopicMessageIdImpl` can extend the base class.
We still need the `messageId` reference. Otherwise, it's not easy to get the
actual message ID in the heap dump.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
