[GitHub] [pulsar] nicoloboschi commented on a diff in pull request #19357: [fix][txn] Fix the incorrect log of Transaction Builder

[via GitHub]

nicoloboschi commented on code in PR #19357:
URL: https://github.com/apache/pulsar/pull/19357#discussion_r1090785053


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/transaction/TransactionBuilderImpl.java:
##########
@@ -59,14 +59,14 @@ public CompletableFuture<Transaction> build() {
         transactionCoordinatorClient
                 .newTransactionAsync(txnTimeout, timeUnit)
                 .whenComplete((txnID, throwable) -> {
-                    if (log.isDebugEnabled()) {
-                        log.debug("Success to new txn. txnID: {}", txnID);
-                    }
                     if (throwable != null) {
                         log.error("New transaction error.", throwable);
                         future.completeExceptionally(throwable);
                         return;
                     }
+                    if (log.isDebugEnabled()) {
+                        log.debug("Success to new txn. txnID: {}", txnID);

Review Comment:
   ```suggestion
                           log.debug("'newTransaction' command completed 
successfully for transaction: {}", txnID);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org