BewareMyPower commented on code in PR #182: URL: https://github.com/apache/pulsar-client-cpp/pull/182#discussion_r1091385752
########## wireshark/pulsarDissector.cc: ########## @@ -16,15 +16,13 @@ * specific language governing permissions and limitations * under the License. */ -#include <config.h> #include <epan/column-utils.h> #include <epan/dissectors/packet-tcp.h> -#include <epan/expert.h> #include <epan/packet.h> -#include <epan/prefs.h> #include <epan/proto.h> #include <epan/value_string.h> #include <glib.h> +#include <ws_version.h> Review Comment: This header does not work for the `wireshark-dev` (3.2.3) on Ubuntu. It seems to be caused by the breaking change of the wireshark. Anyway, currently we can focus on the wireshark 4.x support. So this comment is not a blocker. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
