heesung-sn commented on code in PR #19045:
URL: https://github.com/apache/pulsar/pull/19045#discussion_r1091442850
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -202,6 +205,11 @@ public class PersistentTopic extends AbstractTopic
implements Topic, AddEntryCal
private CompletableFuture<Long> currentCompaction =
CompletableFuture.completedFuture(COMPACTION_NEVER_RUN);
private final CompactedTopic compactedTopic;
+ // TODO: Create compaction strategy from topic policy when exposing
strategic compaction to users.
+ private static Map<String, TopicCompactionStrategy> strategicCompactionMap
= Map.of(
+ ServiceUnitStateChannelImpl.TOPIC,
+ new ServiceUnitStateCompactionStrategy());
Review Comment:
Regarding adding strategy in topic policy, I'm wondering that’s
over-engineering at this point since we haven’t agreed to expose this to users.
Also, another property in topic policy would multiply as many as topics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
