Denovo1998 commented on code in PR #17449:
URL: https://github.com/apache/pulsar/pull/17449#discussion_r1092739823
##########
pulsar-common/src/main/java/org/apache/pulsar/common/protocol/Commands.java:
##########
@@ -801,6 +805,20 @@ private static void convertSchema(SchemaInfo schemaInfo,
Schema schema) {
});
}
+ private static void convertAutoConsumeSchema(SchemaInfo schemaInfo, Schema
schema) {
+ schema.setName(schemaInfo.getName())
+ .setSchemaData(schemaInfo.getSchema())
+ .setType(Schema.Type.AutoConsume);
Review Comment:
Here, `setType` is set to `Schema.type.AutoConsume` because the value of
AutoConsume in `Schema.Type` is 21 and the value of AutoConsume in `SchemaType`
is -3. It's an act of convert the AutoConsume schema, so when you say "without
SchemaType", it doesn't seem to mean AutoConsume schema alone. What do you
think of my thoughts here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
