merlimat commented on code in PR #87:
URL:
https://github.com/apache/pulsar-client-python/pull/87#discussion_r1093472361
##########
src/producer.cc:
##########
@@ -34,6 +34,16 @@ MessageId Producer_send(Producer& producer, const Message&
message) {
return messageId;
}
+void Producer_sendAsync(Producer& producer, const Message& msg, SendCallback
callback) {
+ Py_BEGIN_ALLOW_THREADS
+ producer.sendAsync(msg, callback);
+ Py_END_ALLOW_THREADS
+
+ if (PyErr_CheckSignals() == -1) {
Review Comment:
This is in the main thread, irrespective of the callback.
`send_async()` is a potentially blocking operation (when
`block_if_queue_full=True`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
