keenborder786 commented on code in PR #90:
URL:
https://github.com/apache/pulsar-client-python/pull/90#discussion_r1093845654
##########
pulsar/schema/schema_avro.py:
##########
@@ -82,15 +82,6 @@ def decode(self, data):
return self._record_cls(**d)
else:
return d
-
else:
- class AvroSchema(Schema):
- def __init__(self, _record_cls, _schema_definition=None):
- raise Exception("Avro library support was not found. Make sure to
install Pulsar client " +
+ raise Exception("Avro library support was not found. Make sure to install
Pulsar client " +
Review Comment:
@erichare , okay I understand the point that you have raised about
AvroSchema Class being used in other places and exceptions being raised when
fastavro has not been installed. Therefore I have remodified my PR. Can you
please review the latest commit? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
