michaeljmarshall opened a new pull request, #19409: URL: https://github.com/apache/pulsar/pull/19409
PIP: #12105 Fixes: #19311 ### Motivation Implement asynchronous authentication for the `ServerCnx` class. ### Modifications * Update authentication of primary auth data to use the `authenticateAsync` method instead of `authenticate`. The callbacks are all handled on the context's event loop to ensure thread safety. * Update the order in which the `ServerCnx` validates proxied authentication data. The issue is described here #19311. Now, we authenticate the proxy's auth data, then the client's auth data, and then reply with the `Connected` command. * Add failure scenario to the `ServerCnx` so that it correctly fails authentication when a proxy's original auth method triggers multistaged authentication. * Clean up error handling. This results in some slightly different error messages to clients when authentication fails. There is no real contract here, so I think this is a safe change. ### Verifying this change Several new tests are added and some existing tests are updated. ### Does this pull request potentially affect one of the following parts: * Send an error to the proxy if the client's auth data triggers an auth challenge. * Change certain protocol string messages when authentication fails. ### Documentation - [x] `doc-not-needed` ### Matching PR in forked repository PR in forked repository: https://github.com/michaeljmarshall/pulsar/pull/23 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
