Technoboy- commented on code in PR #19410:
URL: https://github.com/apache/pulsar/pull/19410#discussion_r1095754617
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java:
##########
@@ -359,19 +443,46 @@ private static String getLogEventTag(ServiceUnitStateData
data) {
isTransferCommand(data) ? "Transfer:" + data.state() :
data.state().toString();
}
+ private AtomicLong getHandlerTotalCounter(ServiceUnitStateData data) {
+ return getHandlerCounter(data, true);
+ }
+
+ private AtomicLong getHandlerFailureCounter(ServiceUnitStateData data) {
+ return getHandlerCounter(data, false);
+ }
+
+ private AtomicLong getHandlerCounter(ServiceUnitStateData data, boolean
total) {
+ var state = data.state() == null ? Free : data.state();
+ var counter = total
+ ? handlerCounters.get(state).getTotal() :
handlerCounters.get(state).getFailure();
+ if (counter == null) {
+ throw new IllegalStateException("Unknown state:" + state);
+ }
+ return counter;
+ }
+
private void log(Throwable e, String serviceUnit, ServiceUnitStateData
data, ServiceUnitStateData next) {
if (e == null) {
if (log.isDebugEnabled() || isTransferCommand(data)) {
- log.info("{} handled {} event for serviceUnit:{}, cur:{},
next:{}",
+ long handlerTotalCount = getHandlerTotalCounter(data).get();
+ long handlerFailureCount =
getHandlerFailureCounter(data).get();
+ log.info("{} handled {} event for serviceUnit:{}, cur:{},
next:{}, "
+ + "totalHandledRequests{},
totalFailedRequests:{}",
Review Comment:
Seems the log level is `debug`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
