congbobo184 commented on code in PR #18273:
URL: https://github.com/apache/pulsar/pull/18273#discussion_r1095811926
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/transaction/TopicTransactionBufferRecoverTest.java:
##########
@@ -550,7 +558,7 @@ private void checkSnapshotCount(TopicName topicName,
boolean hasSnapshot,
CompletableFuture<Long> compactionFuture = (CompletableFuture<Long>)
field.get(persistentTopic);
Awaitility.await().untilAsserted(() ->
assertTrue(compactionFuture.isDone()));
- Reader<TransactionBufferSnapshot> reader =
pulsarClient.newReader(Schema.AVRO(TransactionBufferSnapshot.class))
+ Reader<GenericRecord> reader =
pulsarClient.newReader(Schema.AUTO_CONSUME())
Review Comment:
we also need to check snapshot index topic has been clean right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
