This is an automated email from the ASF dual-hosted git repository.

xiangying pushed a commit to branch branch-2.10
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/branch-2.10 by this push:
     new b83214e3c5d [fix][broker]fix multi invocation for ledger 
createComplete (#18975)
b83214e3c5d is described below

commit b83214e3c5d4c032d6453ac10d75a5f6da20e0bf
Author: AloysZhang <[email protected]>
AuthorDate: Mon Dec 19 23:41:29 2022 +0800

    [fix][broker]fix multi invocation for ledger createComplete (#18975)
    
    ### Motivation
    
    fix multi invocation for ledger `createComplete`
    
    ### Modifications
    
    Only call `createComplete` at the point of creating ledger timeout if the 
ledger is not created normally
    
    (cherry picked from commit 8f1c1b11e7ac895acc20f9f9ff900583b4af935c)
---
 .../main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
 
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
index 049016b15ea..a05b6e451ac 100644
--- 
a/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
+++ 
b/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
@@ -3843,12 +3843,12 @@ public class ManagedLedgerImpl implements 
ManagedLedger, CreateCallback {
                 if (log.isDebugEnabled()) {
                     log.debug("[{}] Timeout creating ledger", name);
                 }
+                cb.createComplete(BKException.Code.TimeoutException, null, 
ledgerCreated);
             } else {
                 if (log.isDebugEnabled()) {
                     log.debug("[{}] Ledger already created when timeout task 
is triggered", name);
                 }
             }
-            cb.createComplete(BKException.Code.TimeoutException, null, 
ledgerCreated);
         }, config.getMetadataOperationsTimeoutSeconds(), TimeUnit.SECONDS);
     }
 

Reply via email to