Demogorgon314 commented on code in PR #18858:
URL: https://github.com/apache/pulsar/pull/18858#discussion_r1097316112
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -957,6 +957,44 @@ void splitAndOwnBundleOnceAndRetry(NamespaceBundle bundle,
});
}
+ /**
+ * Get the split boundary's.
+ *
+ * @param bundle The bundle to split.
+ * @param boundaries The specified positions,
+ * use for {@link
org.apache.pulsar.common.naming.SpecifiedPositionsBundleSplitAlgorithm}.
+ * @return A pair, left is target namespace bundle, right is split bundles.
+ */
+ public CompletableFuture<Pair<NamespaceBundles, List<NamespaceBundle>>>
getSplitBoundary(
+ NamespaceBundle bundle, List<Long> boundaries) {
+ ServiceConfiguration config = pulsar.getConfig();
+ BundleSplitOption bundleSplitOption;
+ if (config.getDefaultNamespaceBundleSplitAlgorithm()
+
.equals(NamespaceBundleSplitAlgorithm.FLOW_OR_QPS_EQUALLY_DIVIDE)) {
+ Map<String, TopicStatsImpl> topicStatsMap =
pulsar.getBrokerService().getTopicStats(bundle);
+ bundleSplitOption = new
FlowOrQpsEquallyDivideBundleSplitOption(this, bundle, boundaries,
+ topicStatsMap,
+ config.getLoadBalancerNamespaceBundleMaxMsgRate(),
+ config.getLoadBalancerNamespaceBundleMaxBandwidthMbytes(),
+ config.getFlowOrQpsDifferenceThresholdPercentage());
+ } else {
+ bundleSplitOption = new BundleSplitOption(this, bundle,
boundaries);
+ }
+ NamespaceBundleSplitAlgorithm nsBundleSplitAlgorithm =
Review Comment:
Good catch, fixed.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -957,6 +957,44 @@ void splitAndOwnBundleOnceAndRetry(NamespaceBundle bundle,
});
}
+ /**
+ * Get the split boundary's.
+ *
+ * @param bundle The bundle to split.
+ * @param boundaries The specified positions,
+ * use for {@link
org.apache.pulsar.common.naming.SpecifiedPositionsBundleSplitAlgorithm}.
+ * @return A pair, left is target namespace bundle, right is split bundles.
+ */
+ public CompletableFuture<Pair<NamespaceBundles, List<NamespaceBundle>>>
getSplitBoundary(
+ NamespaceBundle bundle, List<Long> boundaries) {
+ ServiceConfiguration config = pulsar.getConfig();
+ BundleSplitOption bundleSplitOption;
+ if (config.getDefaultNamespaceBundleSplitAlgorithm()
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
