aymkhalil commented on PR #19097: URL: https://github.com/apache/pulsar/pull/19097#issuecomment-1419505538
After collecting feedback, I'm closing this PR for now bc: 1. It does not address the consistency problem for auto created topics since those happen on the binary protocol path (i.e. a producer) 2. Concerns about extra overhead of calling the `sync` API on multiple code paths 3. Even if we limit the `sync` API to when ML.asyncOpen() call is attempted, it means that for 100% of topic creation attempt we enforce the sync although the problem happens only in corner cases. The actual impact here is not measured due to lack of data points regarding the `sync` API latency && the frequency of the delete problem (clarified in the next point). 4. The underlying issue (which is creating topics while ns delete is in progress) could be already mitigated to an extent with the delete retries implemented in #19374 So the idea would be to: 1. Monitor if the problem happens again after merging #19374 2. Reproduce the problem 3. Submit another PR for the fix in-light of the above information (please note that all solutions are best effort only as explained here: https://github.com/apache/pulsar/pull/19097#issuecomment-1410930325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
