gaoran10 commented on code in PR #19440:
URL: https://github.com/apache/pulsar/pull/19440#discussion_r1098148880
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/data/BrokerLoadData.java:
##########
@@ -187,4 +191,35 @@ public String toString(ServiceConfiguration conf) {
);
}
+ public List<Metrics> toMetrics(String advertisedBrokerAddress) {
+ var metrics = new ArrayList<Metrics>();
+ var dimensions = new HashMap<String, String>();
+ dimensions.put("metric", "loadBalancing");
+ dimensions.put("broker", advertisedBrokerAddress);
Review Comment:
Normally, every metric will have a label to indicate the broker IP, I'm not
sure whether we need to add the label `broker`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
