poorbarcode commented on code in PR #19433:
URL: https://github.com/apache/pulsar/pull/19433#discussion_r1098936180
##########
pulsar-metadata/src/test/java/org/apache/pulsar/metadata/impl/MetadataStoreFactoryImplTest.java:
##########
@@ -55,11 +55,13 @@ public void resetMetadataStoreProperty() {
@Test
- public void testCreate() throws MetadataStoreException{
+ public void testCreate() throws Exception{
MetadataStore instance = MetadataStoreFactoryImpl.create(
Review Comment:
already fixed
##########
managed-ledger/src/test/java/org/apache/bookkeeper/test/BookKeeperClusterTestCase.java:
##########
@@ -226,6 +226,8 @@ public void tearDown() throws Exception {
if (tearDownException != null) {
throw tearDownException;
}
+ // cleanup for metrics.
+ metadataStore.close();
Review Comment:
already fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
