michaeljmarshall commented on code in PR #19444:
URL: https://github.com/apache/pulsar/pull/19444#discussion_r1100771062


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -475,6 +476,7 @@ protected synchronized void initializeBookKeeper(final 
ManagedLedgerInitializeLe
         }
 
         // Calculate total entries and size
+        final List<Long> emptyLedgersToBeDeleted = new ArrayList<>();

Review Comment:
   Is there a reason we are not using a thread safe list here? I think we might 
need one, though I have not read through all of this code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to