heesung-sn commented on code in PR #19440:
URL: https://github.com/apache/pulsar/pull/19440#discussion_r1101841211
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/data/BrokerLoadData.java:
##########
@@ -187,4 +191,35 @@ public String toString(ServiceConfiguration conf) {
);
}
+ public List<Metrics> toMetrics(String advertisedBrokerAddress) {
+ var metrics = new ArrayList<Metrics>();
+ var dimensions = new HashMap<String, String>();
+ dimensions.put("metric", "loadBalancing");
+ dimensions.put("broker", advertisedBrokerAddress);
Review Comment:
> What I want to express is that the instance label is similar to the broker
dim.
Do you mean these metrics should not contain the `broker` dimension because
`broker` is redundant?
> This is for the backward compatibility as the existing resource usage
metrics have the broker dimension.
As I said above, some existing pulsar metrics explicitly emit this `broker`
dimension, and I kept them here for the backward compatibility.
Since I already added the `broker` dim for all metrics here. At least we are
consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
