lhotari commented on code in PR #19434:
URL: https://github.com/apache/pulsar/pull/19434#discussion_r1102096138


##########
pulsar-client-tools/src/main/java/org/apache/pulsar/client/cli/PulsarClientTool.java:
##########
@@ -76,6 +76,9 @@ public static class RootParams {
 
         @Parameter(names = { "--tlsTrustCertsFilePath" }, description = "File 
path to client trust certificates")
         String tlsTrustCertsFilePath;
+
+        @Parameter(names = { "-m", "--memory", }, description = "Configure the 
Pulsar client memory limit")
+        Long memory=0L;

Review Comment:
   It's pretty unconvenient to specify megabytes as bytes on the command line. 
Do we already have a parser that can accept typical units like M = megabyte 
etc. . 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to