heesung-sn commented on PR #19490: URL: https://github.com/apache/pulsar/pull/19490#issuecomment-1430391756
>@heesung-sn I am concerned about "However, because this is invalid, the tableview will skip this msg, causing an inconsistent view." > If we skip the message when consuming the data, the consumer will only receive it again if the consumer disconnects. The read position of the cursor will move to the end of the topic, after the topic compaction task done, the compacted data will not dispatch to the consumer again. Is it will be a problem in this case? >> Good point. >> >> we should change the condition and accept all compacted messages are valid transitions (even if the prev msg is not null). I misunderstood what you said. Please ignore my above comment. I will close this PR and propose another solution without msg properties because, as you commented, topic cursors can reset to compaction horizon, which won't have message properties. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
