michaeljmarshall commented on code in PR #19517:
URL: https://github.com/apache/pulsar/pull/19517#discussion_r1106630819
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -2555,7 +2556,7 @@ private CompletableFuture<Boolean>
verifyTxnOwnership(TxnID txnID) {
} else {
return CompletableFuture.completedFuture(false);
}
- });
+ }, ctx.executor());
Review Comment:
I requested this change last week because `getAuthenticationData()` was
getting a non-volatile variable. However, before this PR was opened, I
contributed #19507. @nicoloboschi - we can probably remove this part of the
diff since reading the `authenticationData` is now thread safe.
In the long term, it might be worth exploring if we should only read this
metadata from the event loop, but for now, these variables are volatile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
