poorbarcode opened a new pull request, #19545:
URL: https://github.com/apache/pulsar/pull/19545

   ### Motivation
   
   In the test 
`ManagedLedgerErrorsTest.recoverLongTimeAfterMultipleWriteErrors`, it mocks two 
errors of add entries, then verify that the final write succeeds.
   
   But the first write failure triggers two other operations: `delete current 
ledger` and `create a new ledger`, these two operations have the probability of 
consuming the error events that were mocked earlier. As a result, the intent of 
the test is not being performed correctly.  If the error event is consumed by 
`create a new ledger`, it will make the test unstable, see: 
https://github.com/apache/pulsar/actions/runs/4195006942/jobs/7274314432
   
   ### Modifications
   
   Use a specific method when we only need to mock a failed event of add entry.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: 
   - https://github.com/poorbarcode/pulsar/pull/70
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to