shibd commented on code in PR #298:
URL: 
https://github.com/apache/pulsar-client-node/pull/298#discussion_r1111630198


##########
docs/release-process.md:
##########
@@ -150,13 +150,23 @@ and create a Pull Request on GitHub.
 
 #### 6. Publish the release candidate to the npm
 
-Set the npm version for the release candidate
+If you don't have permission to publish `pulsar-client` to the npm registry, 
ask other committers to grant that permission.
+
 ```sh
-npm version 1.8.0-rc.1 --no-git-tag-version
-```
+# Set the npm version for the release candidate
+npm version 1.x.0-rc.1 --no-git-tag-version
+
+# Create or verify a user account in the npm registry
+$ npm adduser
+
+Username: foobar
+Password: ********
+Email: (this IS public) [email protected]
 
-You can use `npm pack` and test the package before publishing. 
-If there are no problems, then use `npm publish` to publish to the npm.
+# Publish the rc version package to the npm registry
+# We use the `rc` tag to distinguish the release candidate from the official 
release.
+$ npm publish --tag rc

Review Comment:
   If tag is set, this version will not be latest. 
   
   https://docs.npmjs.com/cli/v9/commands/npm-dist-tag#description
   ```
   Publishing a package sets the latest tag to the published version unless the 
--tag option is used. For example, npm publish --tag=beta.
   
   By default, npm install <pkg> (without any @<version> or @<tag> specifier) 
installs the latest tag.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to