michaeljmarshall commented on code in PR #19597:
URL: https://github.com/apache/pulsar/pull/19597#discussion_r1114685486
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarChannelInitializer.java:
##########
@@ -213,17 +213,16 @@ CompletableFuture<Channel> initSocks5IfConfig(Channel ch)
{
CompletableFuture<Channel> initializeClientCnx(Channel ch,
InetSocketAddress
logicalAddress,
- InetSocketAddress
resolvedPhysicalAddress) {
+ InetSocketAddress
resolvedPhysicalAddress,
+ InetSocketAddress
unresolvedPhysicalAddress) {
Review Comment:
We were using this address for `cnx.setRemoteHostName(...);` before. In
order to maintain consistency, I think we should consider doing that in this PR
too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
