BewareMyPower commented on PR #300: URL: https://github.com/apache/pulsar-client-node/pull/300#issuecomment-1441227560
This PR is okay but I think it does not essentially solve the issue. With this PR, the macOS users might feel good. But for Linux users, they might still have to configure the `tlsTrustCertsFilePath`. For example, after https://github.com/apache/pulsar-client-node/pull/288, which is included in Node.js client 1.8.1, the Node.js client was built on CentOS 7 for glibc based Linux. The bundled CA path is `/etc/pki/tls/certs/ca-bundle.crt`. So when I ran an example on Ubuntu 20.04, I have to add the following config: ```javascript tlsTrustCertsFilePath: '/etc/ssl/certs/ca-certificates.crt' ``` However, with Node.js client 1.8.0, which was built on Node.js container that is based on Debian, the bundled CA path is `/etc/ssl/certs/ca-certificates.crt` so I didn't need to configure `tlsTrustCertsFilePath`. Of course, it does not work on RedHat based Linux distros. In conclusion, it's a trade-off of the convenience to install the client without building the C++ add-on locally. Users could also solve this issue by copying the cert to a certain directory without any code change. I might move the discussion to mail list later. But for now it's also good to hear your opinions. @eolivelli @nicoloboschi @shibd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
