nodece opened a new pull request, #19608:
URL: https://github.com/apache/pulsar/pull/19608

   ### Motivation
   
   We set the TLS and auth on the `ClusterData`. When using the geo-replication 
feature, the Broker only read the TLS and auth config from the Pulsar config 
for creating the admin, and the broker ignores the `ClusterData` config. In 
fact, the `ClusterData` actually takes precedence over the Pulsar config.
   
   ### Modifications
   
   - Fix the auth config, when is `null`, fallback to the Pulsar config
   - Fix the TLS config
      - When `ClusterData#isBrokerClientTlsEnabled` is `true`, use the TLS 
config from `ClusterData`
      - When `ClusterData#isBrokerClientTlsEnabled` is `false`, fallback to the 
Pulsar config
   
   This logic is the same with the 
`org.apache.pulsar.broker.service.BrokerService#getReplicationClient`.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to