Demogorgon314 commented on code in PR #19538:
URL: https://github.com/apache/pulsar/pull/19538#discussion_r1118111162
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannel.java:
##########
@@ -150,6 +151,18 @@ public interface ServiceUnitStateChannel extends Closeable
{
*/
CompletableFuture<Void> publishSplitEventAsync(Split split);
+ /**
+ * Asynchronously publishes the service unit unload event to the system
topic in this channel,
+ * and wait to unload operation complete.
+ *
+ * @param unload (unload specification object)
+ * @param timeout The unload operation timeout.
+ * @param timeoutUnit The unload operation timeout unit.
+ * @return the completable future object staged from the event message
sendAsync.
+ */
+ CompletableFuture<Void> publishUnloadEventAndWaitUnloadComplete(
Review Comment:
Good point!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
