michaeljmarshall commented on code in PR #19503:
URL: https://github.com/apache/pulsar/pull/19503#discussion_r1119256068
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/Stat.java:
##########
@@ -55,4 +62,9 @@ public class Stat {
* Whether the key-value pair had been created within the current
"session".
*/
final boolean createdBySelf;
+
+ /**
+ * Whether this is the first version of the key-value pair since it has
been last created.
+ */
+ final boolean firstVersion;
Review Comment:
Nit: does this always imply created? If so, why not use `boolean created`
instead of tying the meaning to the concept of `version`? Based on the usage of
this field in the PR, we want to know if this was a creation or a modification
event, not if it was the `firstVersion`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
