shibd commented on code in PR #16533:
URL: https://github.com/apache/pulsar/pull/16533#discussion_r1120225388
##########
pulsar-common/src/main/java/org/apache/pulsar/common/topics/TopicList.java:
##########
@@ -56,6 +57,12 @@ public static List<String> filterTopics(List<String>
original, Pattern topicsPat
.collect(Collectors.toList());
}
+ public static List<String> filterTransactionInternalName(List<String>
original) {
+ return original.stream()
+ .filter(topic ->
!SystemTopicNames.isTransactionInternalName(TopicName.get(topic)))
Review Comment:
Why just filter transaction internal name? Something
like(`__transaction_buffer_snapshot`, `__transaction_buffer_snapshot_segments`,
`__transaction_buffer_snapshot_indexes`) these doesn't seem to be filtered out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
