shibd commented on PR #955: URL: https://github.com/apache/pulsar-client-go/pull/955#issuecomment-1449265003
> And I don't get why do we have to wrap a conditional variable? The native cond does not support timeout wait, and mainly wants to control the timeout or cancel the wait through context. https://github.com/apache/pulsar-client-go/pull/955/files#diff-d4362cb0b0046577b68820bba2bde37b97ca5d7db7237e4e4b5eac54d7aa8bc3R89-R120 > We can achieve the same goal with the channel itself, Do you want `mem_controller_limit` all the methods into the channel first, and then select to read the signal and process it? Similar to #957 `ackGroupingTracker `? > or just reuse the Semaphore [here](https://github.com/apache/pulsar-client-go/blob/master/pulsar/internal/semaphore.go) This semaphore can only process applications or release 1 signal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
